Support custom configuration file location #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rience would you mind getting unit tests to pass before I take another look at this? Happy to get this feature added as the use case makes sense. |
|
@drwl thanks for checking this PR. Tests should now be green. |
|
@rience I merged in some other PRs recently. Would you be able to resolve merge conflicts? |
|
I have some downtime and am tidying up the project. I'm going to close this PR for now, but feel free to re-open it if this is something you still want to try and get into the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our company we're using this gem in monorepo - where there are multiple Rails applications and Rails engines. This PR allows to specify custom location for configuration file so it can be shared across multiple applications.